Closed
Conversation
vroldanbet
approved these changes
Sep 24, 2025
Contributor
|
I found an alternative way how to solve the duplicate classes issue: #151 |
Contributor
Author
|
Thanks for the alternate! I'm going to close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145
Description
In #141, we stopped bringing in the proto piecemeal and let
buf exportbring in all of the transitive dependencies. This means that we're generating the declarations for the google well-known types, which is why we were seeing complaints of duplicates in the reported issue. This changes the dependency declaration to exclude those well-known types.Changes
=Testing
Review. See that everything still passes.